Remove the GaussianProcesses based and Loess interpolations #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Jun 23, 2020
Member
ChrisRackauckas
left a comment
ChrisRackauckas
left a comment
There was a problem hiding this comment.
agreed on these. Just set it up for the next release as well
|
The tutorial linked from the README still refers to these two methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GaussianProcesses based interpolation has made it difficult to keep this package up to date because it's a heavy dependency that is rarely updated with new compat bounds.
The Loess interpolation has never been properly tested and it seems to produce wrong results in some cases. Eventually, we should add a version based on Loess.jl but for now it's better remove it.