multiple_shoot for EnsembleProblem
#602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/multiple_shooting.jl
Outdated
Comment on lines
155
to
156
| loss_function::Function, | ||
| continuity_loss::Function, |
Member
There was a problem hiding this comment.
This stops specialization BTW
Author
There was a problem hiding this comment.
I have removed the type specification ::Function. Is that what you had in mind?
Comment on lines
227
to
260
| function multiple_shoot( | ||
| p::AbstractArray, | ||
| ode_data::AbstractArray, | ||
| tsteps::AbstractArray, | ||
| ensembleprob::EnsembleProblem, | ||
| ensemblealg::SciMLBase.BasicEnsembleAlgorithm, | ||
| loss_function::Function, | ||
| solver::DiffEqBase.AbstractODEAlgorithm, | ||
| group_size::Integer; | ||
| continuity_term::Real=100, | ||
| kwargs... | ||
| ) | ||
| # Continuity loss between last state in previous prediction | ||
| # and current initial condition in ode_data | ||
| function continuity_loss(û_end, u_0) | ||
| return sum(abs, û_end - u_0) | ||
| end | ||
|
|
||
| return multiple_shoot( | ||
| p, | ||
| ode_data, | ||
| tsteps, | ||
| ensembleprob, | ||
| ensemblealg, | ||
| loss_function, | ||
| continuity_loss, | ||
| solver, | ||
| group_size; | ||
| continuity_term, | ||
| kwargs... | ||
| ) | ||
|
|
||
| end | ||
|
|
Member
There was a problem hiding this comment.
we should really move the optional argument to last
Author
There was a problem hiding this comment.
I am not sure what you mean by that.
Member
There was a problem hiding this comment.
the reason for this dispatch is to handle the optional argument, but it really shouldn't be one of the ones in the middle then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR overloads the
multiple_shootfunction, so that it can be called with problems of typeEnsembleProblem.This is quite useful 😀
It is a suggestion for issue #601.