Simple quick fix for refactor issue #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 64.00% 64.22% +0.22%
==========================================
Files 9 9
Lines 625 629 +4
==========================================
+ Hits 400 404 +4
Misses 225 225
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Okay I'm not sure I understand how switching a test from E: nevermind it had to update I guess |
|
What exactly do you want KLU and UMFPACK to do on a SingularException? |
|
Am I good to merge this, we can solve the SingularException question in a different PR? |
|
Yes, I want to solve the other issue with retcodes, but we need enum retcodes first SciML/SciMLBase.jl#274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisRackauckas acceptable? I'll add a check option to UMFPACK for 1.9, and figure out how I want to do this in KLU. But this should suffice for now, we can always set
check = falsedefault later once those checks are integrated upstream.