From b1ad96d5f3e1353151f9489abbe059f47a3887ad Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Wed, 12 Nov 2025 08:07:04 -0500 Subject: [PATCH 1/3] Remove TriangularSolve dependency Removed 'TriangularSolve' dependency from Project.toml. --- Project.toml | 2 -- 1 file changed, 2 deletions(-) diff --git a/Project.toml b/Project.toml index f7b1866cc..1eec7d0e6 100644 --- a/Project.toml +++ b/Project.toml @@ -27,7 +27,6 @@ SciMLLogging = "a6db7da4-7206-11f0-1eab-35f2a5dbe1d1" SciMLOperators = "c0aeaf25-5076-4817-a8d5-81caf7dfa961" Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46" StaticArraysCore = "1e83bf80-4336-4d27-bf5d-d5a4f845583c" -TriangularSolve = "d5829a12-d9aa-46ab-831f-fb7c9ab06edf" UnPack = "3a884ed6-31ef-47d7-9d2a-63182c4928ed" [weakdeps] @@ -139,7 +138,6 @@ StableRNGs = "1.0" StaticArrays = "1.9" StaticArraysCore = "1.4.3" Test = "1.10" -TriangularSolve = "0.2.1" UnPack = "1.0.2" Zygote = "0.7" blis_jll = "0.9.0" From 2cb7d424cdf4e4e37405336255102a4aa9bec0c4 Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Wed, 12 Nov 2025 08:07:36 -0500 Subject: [PATCH 2/3] Update LinearSolveRecursiveFactorizationExt.jl --- ext/LinearSolveRecursiveFactorizationExt.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/LinearSolveRecursiveFactorizationExt.jl b/ext/LinearSolveRecursiveFactorizationExt.jl index 2bd0b0f73..d0044c3bd 100644 --- a/ext/LinearSolveRecursiveFactorizationExt.jl +++ b/ext/LinearSolveRecursiveFactorizationExt.jl @@ -6,7 +6,7 @@ using LinearSolve: LinearSolve, userecursivefactorization, LinearCache, @get_cac using LinearSolve.LinearAlgebra, LinearSolve.ArrayInterface, RecursiveFactorization using SciMLBase: SciMLBase, ReturnCode using SciMLLogging: @SciMLMessage -using TriangularSolve +using RecursiveFactorization.TriangularSolve LinearSolve.userecursivefactorization(A::Union{Nothing, AbstractMatrix}) = true From 78a9a69585007651d0d9d9ac00075a3ee5eb2dfe Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Wed, 12 Nov 2025 08:27:19 -0500 Subject: [PATCH 3/3] Update LinearSolveRecursiveFactorizationExt.jl --- ext/LinearSolveRecursiveFactorizationExt.jl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ext/LinearSolveRecursiveFactorizationExt.jl b/ext/LinearSolveRecursiveFactorizationExt.jl index d0044c3bd..9dbb9a548 100644 --- a/ext/LinearSolveRecursiveFactorizationExt.jl +++ b/ext/LinearSolveRecursiveFactorizationExt.jl @@ -6,7 +6,6 @@ using LinearSolve: LinearSolve, userecursivefactorization, LinearCache, @get_cac using LinearSolve.LinearAlgebra, LinearSolve.ArrayInterface, RecursiveFactorization using SciMLBase: SciMLBase, ReturnCode using SciMLLogging: @SciMLMessage -using RecursiveFactorization.TriangularSolve LinearSolve.userecursivefactorization(A::Union{Nothing, AbstractMatrix}) = true @@ -132,7 +131,10 @@ function SciMLBase.solve!(cache::LinearSolve.LinearCache, alg::ButterflyFactoriz (;A, b, ws, U, V, out, tmp, n) = workspace b[1:M] .= cache_b mul!(tmp, U', b) - TriangularSolve.ldiv!(F, tmp, thread) + + # TriangularSolve.ldiv! + RecursiveFactorization.ldiv!(F, tmp, thread) + mul!(b, V, tmp) out .= @view b[1:n] SciMLBase.build_linear_solution(alg, out, nothing, cache)