From 786c9b422573888a11790a1c8c20e415d8dd8d7e Mon Sep 17 00:00:00 2001 From: ChrisRackauckas Date: Wed, 12 Nov 2025 11:35:28 -0500 Subject: [PATCH 1/2] Add missing butterfly.jl test to runtests.jl with version check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The butterfly.jl test file was present in the test directory but was not being run as part of the test suite. This test file validates the ButterflyFactorization algorithm with random matrices and Wilkinson matrices. The test is conditionally included only when RecursiveFactorization version 0.2.26 or higher is available, as the butterfly factorization functionality requires that version. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- test/runtests.jl | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/runtests.jl b/test/runtests.jl index c39f973e3..719601e05 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -19,6 +19,16 @@ if GROUP == "All" || GROUP == "Core" @time @safetestset "Traits" include("traits.jl") @time @safetestset "Verbosity" include("verbosity.jl") @time @safetestset "BandedMatrices" include("banded.jl") + # Butterfly test requires RecursiveFactorization 0.2.26+ + if HAS_EXTENSIONS + try + import RecursiveFactorization + if pkgversion(RecursiveFactorization) >= v"0.2.26" + @time @safetestset "Butterfly Factorization" include("butterfly.jl") + end + catch + end + end @time @safetestset "Mixed Precision" include("test_mixed_precision.jl") end From 2f6e28b9ce2b47085a7a96407835929b481736c1 Mon Sep 17 00:00:00 2001 From: ChrisRackauckas Date: Wed, 12 Nov 2025 12:01:42 -0500 Subject: [PATCH 2/2] Add missing butterfly.jl test to runtests.jl MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The butterfly.jl test file was present in the test directory but was not being run as part of the test suite. This test file validates the ButterflyFactorization algorithm with random matrices and Wilkinson matrices. The Project.toml already requires RecursiveFactorization 0.2.26+ which includes the butterfly factorization functionality. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- test/runtests.jl | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index 719601e05..0b5fdef59 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -19,16 +19,7 @@ if GROUP == "All" || GROUP == "Core" @time @safetestset "Traits" include("traits.jl") @time @safetestset "Verbosity" include("verbosity.jl") @time @safetestset "BandedMatrices" include("banded.jl") - # Butterfly test requires RecursiveFactorization 0.2.26+ - if HAS_EXTENSIONS - try - import RecursiveFactorization - if pkgversion(RecursiveFactorization) >= v"0.2.26" - @time @safetestset "Butterfly Factorization" include("butterfly.jl") - end - catch - end - end + @time @safetestset "Butterfly Factorization" include("butterfly.jl") @time @safetestset "Mixed Precision" include("test_mixed_precision.jl") end