Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial solution on PIDE's #216

Merged
merged 33 commits into from
Dec 13, 2022
Merged

Initial solution on PIDE's #216

merged 33 commits into from
Dec 13, 2022

Conversation

Qfl3x
Copy link
Contributor

@Qfl3x Qfl3x commented Dec 7, 2022

See: #183

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #216 (4099db4) into master (4d1b043) will increase coverage by 6.96%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   70.08%   77.05%   +6.96%     
==========================================
  Files          37       38       +1     
  Lines        1899     1931      +32     
==========================================
+ Hits         1331     1488     +157     
+ Misses        568      443     -125     
Impacted Files Coverage Δ
...schemes/centered_difference/centered_difference.jl 100.00% <ø> (ø)
src/interface/solution/timedep.jl 85.29% <ø> (ø)
src/system_parsing/pde_system_transformation.jl 41.80% <88.88%> (+3.11%) ⬆️
src/discretization/discretize_vars.jl 86.66% <100.00%> (+13.33%) ⬆️
...discretization/generate_finite_difference_rules.jl 92.30% <100.00%> (+0.64%) ⬆️
...n/schemes/integral_expansion/integral_expansion.jl 100.00% <100.00%> (ø)
src/scalar_discretization.jl 75.60% <100.00%> (+1.25%) ⬆️
...ion/schemes/upwind_difference/upwind_difference.jl 88.40% <0.00%> (-2.64%) ⬇️
src/discretization/differential_discretizer.jl 97.43% <0.00%> (+2.56%) ⬆️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xtalax
Copy link
Member

xtalax commented Dec 7, 2022

I have added some tests for future cases such as Integral(Interval(xmin, xmax)) and Integral(Interval(a, b)), as well as your euler integrals. We can get to those when people need them, unless you want to have a go.

As a final touch, could you add a tutorial to the docs for integrals? An example like the PIDE you posted would work perfectly.

Thank you for your contribution! :)

@xtalax xtalax merged commit 69a932f into SciML:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants