Fix staggered grid discretization parameter passing #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix MethodError in staggered_discretize.jl by passing prob.p instead of nothing
to prob.f calls. This resolves "MethodError: no method matching view(::Nothing, ::UnitRange{Int64})"
that occurred when using staggered grids with periodic boundary conditions.
The symbolic_trace function was calling prob.f with nothing as the parameters argument,
but the generated ODEFunction expected actual parameters to perform view operations.
Fixes: https://discourse.julialang.org/t/methodoflines-staggered-grids-methoderror-by-function-discretize/133312
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MethodError in staggered_discretize.jl by passing
prob.pinstead ofnothingtoprob.fcalls.This resolves the error
MethodError: no method matching view(::Nothing, ::UnitRange{Int64})that occurred when using staggered grids with periodic boundary conditions.Problem
The
symbolic_tracefunction insrc/discretization/staggered_discretize.jlwas callingprob.fwithnothingas the parameters argument, but the generatedODEFunctionexpected actual parameters to perform view operations on parameter arrays.Solution
Changed lines 33-34 to pass
prob.pinstead ofnothing:Test plan
Fixes: https://discourse.julialang.org/t/methodoflines-staggered-grids-methoderror-by-function-discretize/133312
🤖 Generated with Claude Code