Don't pass to DiffEqBase.ODEProblem invalid keyword check_length #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsas
changed the title
Conflicts: test/odesystem.jl
YingboMa
reviewed
May 18, 2022
|
|
||
| function ODEProblemExpr{iip}(sys::AbstractODESystem,u0map,tspan, | ||
| parammap=DiffEqBase.NullParameters(); | ||
| parammap=DiffEqBase.NullParameters(); check_length=true, |
YingboMa
reviewed
May 18, 2022
Member
YingboMa
left a comment
YingboMa
left a comment
There was a problem hiding this comment.
There are quite a few trailing whitespaces.
Member
Author
|
I had turned that off as I found vscode was having frequent pauses with it on unfortunately... |
Member
Author
|
@YingboMa ok to make a new patch release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1583
If this is ok, would be good to get a bug fix release once merged.