Skip to content

Conversation

@hersle
Copy link
Contributor

@hersle hersle commented Aug 30, 2024

This should fix https://discourse.julialang.org/t/how-do-i-import-t-nounits-with-a-different-name-than-t-in-modelingtoolkit/118640.

The issue was that the @mtkmodel macro internally generates independent variables as "variables", and not "parameters" (which @independent_variables does). I have tried to fix this in a way which is consistent with the rest of the code.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

@ChrisRackauckas ChrisRackauckas merged commit 4cb17cd into SciML:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants