Add NullParaemeters default. #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsas
reviewed
Aug 4, 2020
| u0 = typeof(u0) <: Array{<:Pair} ? u0 : Pair.(rs.states,u0) | ||
| p = typeof(p) <: Array{<:Pair} ? p : Pair.(rs.ps,p) | ||
| function DiffEqBase.ODEProblem(rs::ReactionSystem, u0::Union{AbstractArray, Number}, tspan, p=DiffEqBase.NullParameters(), args...; kwargs...) | ||
| u0 = typeof(u0) <: Union{Array{<:Pair},DiffEqBase.NullParameters} ? u0 : Pair.(rs.states,u0) |
Member
|
Maybe add a test for this too? Even just the example I gave as each problem type? |
Member
Author
|
That would be sensible. Should we have it in Catalyst though? It is a bit confusing that so many of the tests are over there right now, but now mostly all the tests including creating problems and beyond are there, so might make it more consistent. |
Member
|
The whole ReactionSystem should move over to Catalyst IMO, we just need like another week of refactoring the abstract system API |
Member
|
Either location is fine! We just need to remember to include it. |
Member
Author
|
I'll add tests for it over at Catalyst later today. |
Member
|
Sounds good! |
isaacsas
approved these changes
Aug 4, 2020
Member
|
@TorkelE OK to merge? |
Member
Author
|
yes |
This was referenced Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should now be able to create
ReactionSystems without parameters, and create problems fro them. This should no longer yield an error:Solves SciML/Catalyst.jl#239