A bunch of ambiguity fixes #1753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
added a commit
to ChrisRackauckas/ProbNumDiffEq.jl
that referenced
this pull request
Sep 7, 2022
EKCache is the only AbstractODEFilterCache, and so it's safe (at least for now) to extend this function to the other algorithms. The other algorithms were fine because they were using a fallback that has been eliminated by SciML/OrdinaryDiffEq.jl#1753. It would be good to get this patch in so that the ambiguity fix PR can be fully checked.
nathanaelbosch
pushed a commit
to nathanaelbosch/ProbNumDiffEq.jl
that referenced
this pull request
Sep 8, 2022
EKCache is the only AbstractODEFilterCache, and so it's safe (at least for now) to extend this function to the other algorithms. The other algorithms were fine because they were using a fallback that has been eliminated by SciML/OrdinaryDiffEq.jl#1753. It would be good to get this patch in so that the ambiguity fix PR can be fully checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1750