From 82604e5fa6f2a939673d04ad875e18e82fab5a7f Mon Sep 17 00:00:00 2001 From: DhairyaLGandhi Date: Tue, 21 May 2024 15:08:35 +0530 Subject: [PATCH 1/4] chore: move literal_getproperty here --- src/adjoint_common.jl | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/adjoint_common.jl b/src/adjoint_common.jl index 7c356e58d..7cb80017f 100644 --- a/src/adjoint_common.jl +++ b/src/adjoint_common.jl @@ -651,3 +651,13 @@ function out_and_ts(_ts, duplicate_iterator_times, sol) end return out, ts end + +Zygote.@adjoint function Zygote.literal_getproperty(sol::AbstractTimeseriesSolution, + ::Val{:u}) + function solu_adjoint(Δ) + zerou = zero(sol.prob.u0) + _Δ = @. ifelse(Δ === nothing, (zerou,), Δ) + (build_solution(sol.prob, sol.alg, sol.t, _Δ),) + end + sol.u, solu_adjoint +end From 242d10be2e2d71caea8f7e8e3469291ae69c11a6 Mon Sep 17 00:00:00 2001 From: DhairyaLGandhi Date: Tue, 21 May 2024 15:46:09 +0530 Subject: [PATCH 2/4] chore: qualify bukld_solution --- src/adjoint_common.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/adjoint_common.jl b/src/adjoint_common.jl index 7cb80017f..6659174a4 100644 --- a/src/adjoint_common.jl +++ b/src/adjoint_common.jl @@ -657,7 +657,7 @@ Zygote.@adjoint function Zygote.literal_getproperty(sol::AbstractTimeseriesSolut function solu_adjoint(Δ) zerou = zero(sol.prob.u0) _Δ = @. ifelse(Δ === nothing, (zerou,), Δ) - (build_solution(sol.prob, sol.alg, sol.t, _Δ),) + (SciMLBase.build_solution(sol.prob, sol.alg, sol.t, _Δ),) end sol.u, solu_adjoint end From c9d87eea81ebb4141e6a41748674b4a99f1b5d3a Mon Sep 17 00:00:00 2001 From: DhairyaLGandhi Date: Tue, 21 May 2024 17:03:53 +0530 Subject: [PATCH 3/4] chore: import AbstractTimeSeriesSolution --- src/SciMLSensitivity.jl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/SciMLSensitivity.jl b/src/SciMLSensitivity.jl index 7529176bd..d037929f2 100644 --- a/src/SciMLSensitivity.jl +++ b/src/SciMLSensitivity.jl @@ -37,7 +37,8 @@ import SciMLBase: unwrapped_f, _unwrap_val import SciMLBase: AbstractOverloadingSensitivityAlgorithm, AbstractSensitivityAlgorithm, AbstractForwardSensitivityAlgorithm, AbstractAdjointSensitivityAlgorithm, AbstractSecondOrderSensitivityAlgorithm, - AbstractShadowingSensitivityAlgorithm + AbstractShadowingSensitivityAlgorithm, + AbstractTimeSeriesSolution include("parameters_handling.jl") include("sensitivity_algorithms.jl") From ac2f59a1c6b5b8460b202cb4b41b8cfe77092381 Mon Sep 17 00:00:00 2001 From: DhairyaLGandhi Date: Tue, 21 May 2024 17:16:35 +0530 Subject: [PATCH 4/4] chore: fix typo --- src/SciMLSensitivity.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SciMLSensitivity.jl b/src/SciMLSensitivity.jl index d037929f2..5e6156aae 100644 --- a/src/SciMLSensitivity.jl +++ b/src/SciMLSensitivity.jl @@ -38,7 +38,7 @@ import SciMLBase: AbstractOverloadingSensitivityAlgorithm, AbstractSensitivityAl AbstractForwardSensitivityAlgorithm, AbstractAdjointSensitivityAlgorithm, AbstractSecondOrderSensitivityAlgorithm, AbstractShadowingSensitivityAlgorithm, - AbstractTimeSeriesSolution + AbstractTimeseriesSolution include("parameters_handling.jl") include("sensitivity_algorithms.jl")