Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GoogleCharts] Updating of jsapi causes error in GoogleCharts #99

Open
Prakriti-nith opened this issue Jun 23, 2018 · 1 comment
Open

Comments

@Prakriti-nith
Copy link
Contributor

Prakriti-nith commented Jun 23, 2018

Updating the jsapi is causing error in the formation of GoogleCharts. (Refer this comment). For now, I have commented out that portion in this commit.
For the usage of these js files refer updating, limitations and release notes of Google Chart loading.

@Shekharrajak
Copy link
Member

I think we should remove the google chart js files. Anyways at the end, it need internet so having these files in the gem assets folder or directly using the link while using GoogleChart adpater is same (By removing these files will reduce the gem size #127).

I believe Nyaplot way of including script tag should be used in init_script for GoogleChart adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants