New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bunch of lines in rails #115

merged 1 commit into from Aug 4, 2018


None yet
3 participants

Prakriti-nith commented Aug 2, 2018

This PR aims to remove a bunch of lines that occur in the head tag in rails. Dependent JS and CSS files are shifted to vendor/assets/javascripts and vendor/assets/stylesheets respectively. These can be included in the app/assets/javascripts/application.js file as:

//= require highcharts/highcharts                                                           
//= require highcharts/highcharts-more
//= require highcharts/map
//= require googlecharts/google_visualr
//= require googlecharts/loader

and include the below line in head of the layout file:
<%= javascript_include_tag "application" %>

Note: The previous method to use <%=raw Daru::View.dependent_script(:highcharts) %> will also work.


This comment has been minimized.

coveralls commented Aug 2, 2018

Pull Request Test Coverage Report for Build 665

  • 5 of 7 (71.43%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0006%) to 98.015%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/daru/view/adapters/nyaplot/iruby_notebook.rb 0 2 0.0%
Totals Coverage Status
Change from base Build 664: 0.0006%
Covered Lines: 3111
Relevant Lines: 3174

💛 - Coveralls

@Shekharrajak Shekharrajak merged commit 1d178bc into SciRuby:master Aug 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage increased (+0.0006%) to 98.015%

This comment has been minimized.


Shekharrajak commented Aug 4, 2018

Please add examples for these changes and refer it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment