New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disabling of some cops in add_data_in_table method #74

Merged
merged 1 commit into from Feb 17, 2018

Conversation

Projects
None yet
2 participants
@Prakriti-nith
Contributor

Prakriti-nith commented Feb 17, 2018

Is it possible if we can increase the MethodLength to 20 in .rubocop.yml?

@Shekharrajak

This comment has been minimized.

Collaborator

Shekharrajak commented Feb 17, 2018

@Prakriti-nith , Thanks for the PR. It will be better if you work on #67 first.

@Shekharrajak Shekharrajak merged commit cb68153 into SciRuby:master Feb 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Shekharrajak

This comment has been minimized.

Collaborator

Shekharrajak commented Feb 17, 2018

Is it possible if we can increase the MethodLength to 20 in .rubocop.yml?

We are following the daru rubocop configurations.

@Prakriti-nith

This comment has been minimized.

Contributor

Prakriti-nith commented Feb 17, 2018

@Prakriti-nith , Thanks for the PR. It will be better if you work on #67 first.

Sure. I will work on it.

@Prakriti-nith Prakriti-nith deleted the Prakriti-nith:rubocop2 branch May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment