New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RuboCop HandleException in view.rb file #76

Merged
merged 1 commit into from Feb 18, 2018

Conversation

Projects
None yet
2 participants
@Prakriti-nith
Contributor

Prakriti-nith commented Feb 18, 2018

When I enabled HandleException in the plotting_library method, MethodLength increased from 15 to 16. So to avoid the rubocop error, I made few changes which are also reducing the duplication of code.

@Shekharrajak

This comment has been minimized.

Collaborator

Shekharrajak commented Feb 18, 2018

@Prakriti-nith , thanks for the PR. Right now we don't have testcases written for the file view.rb . Please add testcases, for the changes, to check it is not breaking anything. Have a look on other spec files e.g. specs/plot_spec.rb to get idea.

updated: written few specs at #77

@Shekharrajak

This comment has been minimized.

Collaborator

Shekharrajak commented Feb 18, 2018

Since newly created specs at #77 are passing, merging it .

@Shekharrajak Shekharrajak merged commit 3cb4de9 into SciRuby:master Feb 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Prakriti-nith Prakriti-nith deleted the Prakriti-nith:rubocop3 branch May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment