Added a basic scatterplot for Magick backend #45
Conversation
lib/rubyplot/artist/figure.rb
Outdated
| @@ -108,6 +108,9 @@ def write(file_name, device: :file) | |||
| Rubyplot.backend.canvas_height = @height | |||
| Rubyplot.backend.canvas_width = @width | |||
| Rubyplot.backend.figure = self | |||
| if ENV["RUBYPLOT_BACKEND"] == "MAGICK" | |||
There was a problem hiding this comment.
FInd a way to move this to the backend. I don't want anything backend specific in the front end.
If you feel a compulsive need to do something like this, we should change the whole design and not do such patch work. Such things dont scale.
There was a problem hiding this comment.
I will try to find a way to add it into the magick backend, one another way would be to add this function to GR backend as well.
There was a problem hiding this comment.
I want to merge this PR, however I cannot do it unless you remove the if here. Please resolve this on priority before starting work for this week.
There was a problem hiding this comment.
[Commit Link]
Done, shifted it to backend, the task is performed during init_output_device
|
Code is good overall, but you need to improve this plot. Please proceed with the rest of your project. |
allow specifying separate fill and border marker color for markers
…e, implemented circle and plus markers
|
Have merged. You can start work on ticks and any front end changes that you might need now. |
I Passed the rspec test for scatterplot for Magick backend and set up basic functions for Magick backend.
I modified the Magick backend so that it can:
Since, GR and Magick backend uses different units for sizes, for now I have multiplied the transform function with a hard-coded value 10. I will find a suitable factor to multiply for a normalized scale for all backends. Also, no ticks are implemented in the x and y axis, I will add ticks in future.
Currently the implemented scatterplot looks like this:
Please review my changes.