New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing linear regression support in Statsample #53

Open
lokeshh opened this Issue Jul 21, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@lokeshh

lokeshh commented Jul 21, 2016

I think its reasonable to remove linear regression support in Statsample because of following reasons:

  • Its equivalent which is Normal regression lies in Statsample-GLM
  • This way all regression models would lie in Statsample-GLM
  • Statsample-GLM already supports predicting on new data which Statsample doesn't yet
  • Normal regression in Statsample-GLM works without an intercept providing more flexibility
  • This will keep regression models management limited to Statsample-GLM and Statsample gem would be responsible for other statistic tools other than regression, hence simplifying the management.
@v0dro

This comment has been minimized.

Show comment
Hide comment
@v0dro

v0dro Jul 21, 2016

Member

Works. Go ahead.

Member

v0dro commented Jul 21, 2016

Works. Go ahead.

@lokeshh

This comment has been minimized.

Show comment
Hide comment
@lokeshh

lokeshh Jul 21, 2016

@v0dro Ok. Well, then it also implies #51 would be no longer needed. Right?

lokeshh commented Jul 21, 2016

@v0dro Ok. Well, then it also implies #51 would be no longer needed. Right?

@v0dro

This comment has been minimized.

Show comment
Hide comment
@v0dro

v0dro Jul 21, 2016

Member

Are there any particular cases in statsample that are not covered in statsample-glm? If no, then you can safely remove linear regression from statsample and not re-implement the formula language in this gem too (I think that's what you're doing given the commits in #51 - I've been out on vacation so could not follow up on daily activities).

Member

v0dro commented Jul 21, 2016

Are there any particular cases in statsample that are not covered in statsample-glm? If no, then you can safely remove linear regression from statsample and not re-implement the formula language in this gem too (I think that's what you're doing given the commits in #51 - I've been out on vacation so could not follow up on daily activities).

@lokeshh

This comment has been minimized.

Show comment
Hide comment
@lokeshh

lokeshh Jul 22, 2016

Yes you are right. I was implementing formula language in #51. I'm removing it now and will now add a PR to remove multiple regression.

lokeshh commented Jul 22, 2016

Yes you are right. I was implementing formula language in #51. I'm removing it now and will now add a PR to remove multiple regression.

@lokeshh

This comment has been minimized.

Show comment
Hide comment
@lokeshh

lokeshh Aug 7, 2016

Statsample is much faster than Statsample-GLM as these benchmark shows.

lokeshh commented Aug 7, 2016

Statsample is much faster than Statsample-GLM as these benchmark shows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment