Fixes Extended grammar optimization mode would crash if TopK sampling is set to zero. #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TopK sampling is set to zero.
martindevans
approved these changes
Oct 19, 2025
Member
|
Thanks for fixing this. I'm not sure what's wrong the the docs updater action, but I don't think it's anything wrong with this PR. |
Contributor
Author
|
You're very welcome, I'm just happy I can run structured output properly :) (And yeah, I doubt it has anything to do with my change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crash I identified in #1281 between grammar optimization and TopK sampling. In summary, now the
GrammarOptimizationMode.Extendedcode runs only if TopK is set to something above zero.