New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sped-up repeated documentation building. #242

Merged
merged 2 commits into from Mar 13, 2013

Conversation

Projects
None yet
3 participants
@pelson
Member

pelson commented Mar 12, 2013

Repeated documentation build time goes from ~38 seconds to ~8.

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson Mar 12, 2013

Member

Closes #229

Member

pelson commented Mar 12, 2013

Closes #229

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson Mar 12, 2013

Member

Closing until some issues are fixed.

Member

pelson commented Mar 12, 2013

Closing until some issues are fixed.

@pelson pelson closed this Mar 12, 2013

@pelson pelson reopened this Mar 12, 2013

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson Mar 12, 2013

Member

Closing until some issues are fixed.

I've fixed in-place. Hopefully I caught this early enough so nobody wasted any time reading it before.

Member

pelson commented Mar 12, 2013

Closing until some issues are fixed.

I've fixed in-place. Hopefully I caught this early enough so nobody wasted any time reading it before.

Show outdated Hide outdated lib/cartopy/sphinxext/gallery.py Outdated
@esc24

This comment has been minimized.

Show comment
Hide comment
@esc24

esc24 Mar 12, 2013

Member

I'm surprised the same_contents() make much difference as I'd have thought the majority of time was spent generating the rst not writing it to file.

Member

esc24 commented Mar 12, 2013

I'm surprised the same_contents() make much difference as I'd have thought the majority of time was spent generating the rst not writing it to file.

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson Mar 12, 2013

Member

It's not the writing to file that is the problem, it's the modification date that changes which triggers a rebuild with sphinx that is slow.

Member

pelson commented Mar 12, 2013

It's not the writing to file that is the problem, it's the modification date that changes which triggers a rebuild with sphinx that is slow.

@esc24

This comment has been minimized.

Show comment
Hide comment
@esc24

esc24 Mar 12, 2013

Member

Understood. I hadn't twigged that sphinx is also doing its own modification time check as well so if you output the rst it triggers a rebuild.

Member

esc24 commented Mar 12, 2013

Understood. I hadn't twigged that sphinx is also doing its own modification time check as well so if you output the rst it triggers a rebuild.

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson Mar 12, 2013

Member

Thanks @esc24 - think that's all?

Member

pelson commented Mar 12, 2013

Thanks @esc24 - think that's all?

@esc24

This comment has been minimized.

Show comment
Hide comment
@esc24

esc24 Mar 12, 2013

Member

Yes that's all. I'll spend a couple of minutes experimenting on my mac tomorrow but I don't foresee any issues.

Member

esc24 commented Mar 12, 2013

Yes that's all. I'll spend a couple of minutes experimenting on my mac tomorrow but I don't foresee any issues.

esc24 added a commit that referenced this pull request Mar 13, 2013

Merge pull request #242 from pelson/doc_build_speedup
Sped-up repeated documentation building.

@esc24 esc24 merged commit 27019c4 into SciTools:v0.6.x Mar 13, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment