New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-cut when transforming PlateCarree -> PlateCarree in mpl. #260

Merged
merged 5 commits into from Apr 12, 2013

Conversation

Projects
None yet
2 participants
@pelson
Member

pelson commented Apr 8, 2013

Speeds up one PlateCarree contour from 15s to 8s.

A selection of performance test user-code will be available in the near future (not this PR).

@pelson pelson closed this Apr 8, 2013

@pelson pelson reopened this Apr 8, 2013

@rhattersley

This comment has been minimized.

Show comment
Hide comment
@rhattersley

rhattersley Apr 10, 2013

Member

👍 for this change in principle, but there are some detail issues to resolve.

Member

rhattersley commented Apr 10, 2013

👍 for this change in principle, but there are some detail issues to resolve.

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson Apr 10, 2013

Member

@rhattersley - I've now updated this PR.

Member

pelson commented Apr 10, 2013

@rhattersley - I've now updated this PR.

@rhattersley

This comment has been minimized.

Show comment
Hide comment
@rhattersley

rhattersley Apr 10, 2013

Member

I've now updated this PR.

That's much nicer - thank you 😄

I'll have a proper look through now...

Member

rhattersley commented Apr 10, 2013

I've now updated this PR.

That's much nicer - thank you 😄

I'll have a proper look through now...

Show outdated Hide outdated lib/cartopy/crs.py
Show outdated Hide outdated lib/cartopy/crs.py
Show outdated Hide outdated lib/cartopy/crs.py
@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson Apr 12, 2013

Member

I've done all actions bar the one I've commented on. Lets thrash this out and merge in the next 2 hours 😉.

Thanks for the review @rhattersley.

Member

pelson commented Apr 12, 2013

I've done all actions bar the one I've commented on. Lets thrash this out and merge in the next 2 hours 😉.

Thanks for the review @rhattersley.

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson Apr 12, 2013

Member

Just added a commit which addresses the try except.

Member

pelson commented Apr 12, 2013

Just added a commit which addresses the try except.

@rhattersley

This comment has been minimized.

Show comment
Hide comment
@rhattersley

rhattersley Apr 12, 2013

Member

Nice work @pelson 😄

It's faster and it's cleaned out some hacky code from the InterProjectionTransform. 👍

Member

rhattersley commented Apr 12, 2013

Nice work @pelson 😄

It's faster and it's cleaned out some hacky code from the InterProjectionTransform. 👍

rhattersley added a commit that referenced this pull request Apr 12, 2013

Merge pull request #260 from pelson/plate_carree_performance
Short-cut when transforming PlateCarree -> PlateCarree in mpl.

@rhattersley rhattersley merged commit 767b85d into SciTools:master Apr 12, 2013

1 check passed

default The Travis build passed
Details
@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson Apr 12, 2013

Member

Thanks @rhattersley .

Member

pelson commented Apr 12, 2013

Thanks @rhattersley .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment