New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSNI projection. #263

Merged
merged 1 commit into from May 21, 2013

Conversation

Projects
None yet
2 participants
@bjlittle
Member

bjlittle commented Apr 15, 2013

This PR adds the OS NI projection and corrects the image detection for a target domain and zoom level.

Note that, when creating an image nest from directory sources using NestedImageCollection.from_configuration(), the order of the directory sources is automatically sorted by largest area - thus removing this order requirement from the user.

Module doc-strings have also been added.

@pelson

View changes

Show outdated Hide outdated lib/cartopy/io/img_nest.py
@@ -552,6 +552,36 @@ def y_limits(self):
return (0, 13e5)
class OSNI(Projection):

This comment has been minimized.

@pelson

pelson Apr 22, 2013

Member

Can you add a test to check some well known points in this coordinate system?

@pelson

pelson Apr 22, 2013

Member

Can you add a test to check some well known points in this coordinate system?

This comment has been minimized.

@bjlittle

bjlittle Apr 30, 2013

Member

Added a sanity test, done!

@bjlittle

bjlittle Apr 30, 2013

Member

Added a sanity test, done!

@pelson

View changes

Show outdated Hide outdated lib/cartopy/tests/test_img_nest.py
@pelson

View changes

Show outdated Hide outdated lib/cartopy/io/img_nest.py
@pelson

View changes

Show outdated Hide outdated lib/cartopy/io/img_nest.py
@pelson

View changes

Show outdated Hide outdated lib/cartopy/io/img_nest.py
@pelson

View changes

Show outdated Hide outdated lib/cartopy/io/img_nest.py

@ghost ghost assigned pelson Apr 24, 2013

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson Apr 24, 2013

Member

A few actions, but nothing major. Good stuff @bjlittle!

Member

pelson commented Apr 24, 2013

A few actions, but nothing major. Good stuff @bjlittle!

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson May 1, 2013

Member

Ready for merge: 25ac697

Please add a new commit which adds a what's new section & I will happily merge. Nice work @bjlittle!

Member

pelson commented May 1, 2013

Ready for merge: 25ac697

Please add a new commit which adds a what's new section & I will happily merge. Nice work @bjlittle!

@bjlittle

This comment has been minimized.

Show comment
Hide comment
@bjlittle

bjlittle May 1, 2013

Member

Excellent! Thanks @pelson!

Updated the what's new section, good to go 👍

Member

bjlittle commented May 1, 2013

Excellent! Thanks @pelson!

Updated the what's new section, good to go 👍

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson May 1, 2013

Member

Please add a new commit which adds a what's new section

I said add a new commit... Do you still have your old commit (25ac697)? Otherwise I'll have to go over the whole thing again.

Member

pelson commented May 1, 2013

Please add a new commit which adds a what's new section

I said add a new commit... Do you still have your old commit (25ac697)? Otherwise I'll have to go over the whole thing again.

pelson added a commit that referenced this pull request May 21, 2013

@pelson pelson merged commit fbbec9f into SciTools:master May 21, 2013

@pelson

This comment has been minimized.

Show comment
Hide comment
@pelson

pelson May 21, 2013

Member

I've merged this manually @bjlittle. Thanks for this new addition.

Member

pelson commented May 21, 2013

I've merged this manually @bjlittle. Thanks for this new addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment