Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix improper application of deg2rad/rad2deg in _crs.pyx #625
Modified transform_points in _crs.pyx to only apply rad2deg/deg2rad on the first 2 elements of the result (the lat and lon, not the height in meters). Added a test to test_crs.py to verify the result.
As far as I can tell, the test I added passes, although one other test in test_crs.py fails (looks like a significant digit issue in the test).
Fixes issue #623 .
Please review to make sure everything looks good, this is my first attempt at contributing!
There is a lot of noise on the travis tests at present. I'm keen to solve that, but in the meantime, I wouldn't hold this up for it.
In terms of the tests I can clearly see that are failing as a result of this:
There are two numerical test failiures that I'm confident aren't as a result of this change:
@pelson Thanks! I made the spaces fixes...
@QuLogic was something like this what you had in mind? It's slightly more code, but yes less copying.
I sent the CLA, thanks for the requirement info!