Add load support for GRIB2 GDT 12. #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
There was a problem hiding this comment.
NB. There's a bug in the ECMWF GRIB API which causes it to interpret this 32-bit float as an integer ... so this will probably give rubbish results for a genuine message.
Member
Author
There was a problem hiding this comment.
It's probably simplest to check the type of scale and if it's an int do the reverse of the float32->int32 workaround in #1480.
Member
Author
There was a problem hiding this comment.
I've added the check for an int in a second commit.
rhattersley
force-pushed
the
grib2-gdt12
branch
2 times, most recently
from
66645cf to
01c3880
Compare
Member
Author
There was a problem hiding this comment.
I took it that our philosophy with the new GRIB loader is to explode if we don't know what to do, rather than give ambiguous results.
rhattersley
force-pushed
the
grib2-gdt12
branch
from
04c63c5 to
c4675bd
Compare
esc24
added a commit
that referenced
this pull request
Dec 4, 2014
Add load support for GRIB2 GDT 12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.