Removed __future__ imports #3505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
trexfeathers
requested changes
Nov 4, 2019
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Hi @stephenworsley, I think __future__ references also need removing from:
- setup.py:1
- tools/gen_stash_refs.py:27-28
Thanks!
lib/iris/tests/unit/analysis/trajectory/test_UnstructuredNearestNeighbourRegridder.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@trexfeathers Good catch. |
stephenworsley
force-pushed
the
less_future
branch
from
6af0942 to
d9c24dc
Compare
trexfeathers
approved these changes
Nov 4, 2019
Contributor
|
All good, thanks @stephenworsley 😎 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #3457, all imports from future have been removed, as have all tests for these imports and six imports.