-
Notifications
You must be signed in to change notification settings - Fork 298
Simplify class definitions, remove (object) #3511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Nov 5, 2019
20682d7 to
1e01a4a
Compare
Member
|
@stephenworsley You have a handful of |
8 tasks
Member
|
@stephenworsley Nice. After a quick search, a few cheeky 19:class CoordSystem(object, metaclass=ABCMeta):
./coord_systems.py
66:class CFVariable(object, metaclass=ABCMeta):
790:class CFGroup(MutableMapping, object):
./fileformats/cf.py
388: object.__setattr__(self, name, self[index])
456: object.__setattr__(self, name, value)
466: object.__setattr__(self, name, value)
753:class PPField(object, metaclass=abc.ABCMeta):
./fileformats/pp.py
159:class SymmetricNormalize(mpl_colors.Normalize, object):
./palette.py
3966:class ClassDict(MutableMapping, object):
./cube.py
851: object.__setattr__(self, name, value)
./util.py
21:class CubeArithmeticBroadcastingTestMixin(object, metaclass=ABCMeta):
110:class CubeArithmeticMaskingTestMixin(object, metaclass=ABCMeta):
185:class CubeArithmeticMaskedConstantTestMixin(object, metaclass=ABCMeta):
./tests/unit/analysis/maths/__init__.py
32:class Mixin_register(object, metaclass=abc.ABCMeta):
./tests/unit/merge/test_ProtoCube.py
17:class _MaskedArrayEquality(object, metaclass=ABCMeta):
./tests/unit/tests/test_IrisTest.pyFancy following up with these also? 😄 |
Member
|
Outstanding |
Member
|
@stephenworsley LGTM 👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies class definitions which only inherit from
object.