Skip to content

Conversation

@ehogan
Copy link
Contributor

@ehogan ehogan commented Dec 20, 2019

This pull request moves the calculation of the area weights from __perform to __prepare.

@stephenworsley stephenworsley added this to the v3.0.0 milestone Dec 20, 2019
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stephenworsley stephenworsley merged commit 57c4df5 into SciTools:area_weighted_regridding Dec 20, 2019
@ehogan ehogan deleted the move_weights_to_prepare branch December 20, 2019 18:25
@abooton abooton changed the title Move calculation of area weights from perform to prepare PI-2472: Move calculation of area weights from perform to prepare Dec 24, 2019
abooton added a commit to abooton/iris that referenced this pull request Jan 9, 2020
* pr/3623:
  PI-2472:  Update area weighted regridder to accept different dim data (SciTools#3625)
  PI-2472: Fix issue related to comparison / equality in regridding code (SciTools#3624)
  Remove unused variables in regridding code (SciTools#3620)
  Add docstring and what's new (SciTools#3619)
  Move calculation of area weights from perform to prepare (SciTools#3617)
  PI-2472: Refactor AreaWeightedRegridder (SciTools#3606)
  Test for AreaWeightedRegridder (SciTools#3604)
  Split regrid_area_weighted_rectilinear_src_and_grid into prepare and perform (SciTools#3601)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants