Skip to content

Preserve dtype for wrap_lons #4138

Closed
Rohansjamadagni wants to merge 4 commits into
SciTools:mainfrom
Rohansjamadagni:bug-fix-issue-4119
Closed

Preserve dtype for wrap_lons #4138
Rohansjamadagni wants to merge 4 commits into
SciTools:mainfrom
Rohansjamadagni:bug-fix-issue-4119

Conversation

@Rohansjamadagni

Copy link
Copy Markdown

🚀 Pull Request

Description

Fixes #4119

NOTE: Adding this change resulted in a failure of the cube unit test, so I have added the changes necessary to account the changes in the dtype

@SciTools-assistant SciTools-assistant added the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label May 15, 2021
@Rohansjamadagni

Copy link
Copy Markdown
Author

I have now signed the CLA

Preserves dtype for wrap_lons
@bjlittle bjlittle added the Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton label May 19, 2021
@rcomer

rcomer commented Sep 24, 2021

Copy link
Copy Markdown
Member

Hi @Rohansjamadagni and @jeffreypaul15 , thanks for contributing! Sorry that nobody responded to this sooner - Team Iris have been very busy. There are just a few things to address to get our checks passing:

  • Because this change also includes a commit from @jeffreypaul15, he will also need to sign the CLA.
  • The main branch has moved on since you created your branch, so you will need to rebase to pick up those changes. If you've not done that before, this should work:
git checkout bug-fix-issue-4119
git fetch upstream
git rebase upstream/main
  • Thanks for fixing the unit test to reflect the new behaviour. There is also a doctest that needs updating here. I think it should just be a case of removing the decimal points.

@rcomer

rcomer commented Dec 1, 2021

Copy link
Copy Markdown
Member

Hi @jeffreypaul15, are you able to sign our CLA? We appreciate that you both might not have time to work on this PR anymore, and we can make the required branch changes ourselves if that is the case. However, we are not allowed to accept any commit without a CLA from the author, so we can't take this any further without that.

@rcomer

rcomer commented Mar 18, 2022

Copy link
Copy Markdown
Member

This one has now stalled for some time so I will close it. We can re-open if there is interest but, given that there is now a conflict in cartography.py, it may be just as easy to start again with a new branch and new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton Status: Stalled Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve dtype for wrap_lons

7 participants