Chardata moretests#7101
Merged
trexfeathers merged 12 commits intoJun 9, 2026
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Change to pre-commit config merged from main
(into feature-branch)
Member
Author
|
OK I'm finally happy with this! In my mind, this confirms that the new chardata support facility is "safe to merge"™️ Some issues remains in the original plan though. |
Draft
trexfeathers
requested changes
Jun 8, 2026
trexfeathers
left a comment
Contributor
There was a problem hiding this comment.
- Read through the total changes
- Has this delivered on each checklist item?
- Has this removed all TODO and/or commented code?
Member
Author
|
Weird problem here where GitHub isn't picking up a commit added to the fork branch. |
Member
Author
|
OK I think I covered your comments now? |
eaf35e9
into
SciTools:FEATURE_chardata
24 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6920
List of issues from there ...
_Encodingshould work OK (-> utf-8 default applied)_EncodingPlus: