From cee56e1509478f2d5e94a47e8ed66ac0c8378ac4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Lombra=C3=B1a=20Gonz=C3=A1lez?= Date: Fri, 25 Oct 2019 23:47:42 +0200 Subject: [PATCH] fix(tests): return String instead of Response. It returns a stream and the tests fail. --- test/test_view/test_flickr.py | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/test/test_view/test_flickr.py b/test/test_view/test_flickr.py index a1c807a54c..1f6ceffc62 100644 --- a/test/test_view/test_flickr.py +++ b/test/test_view/test_flickr.py @@ -20,17 +20,17 @@ from flask import Response, session from default import flask_app, with_context + class TestFlickrOauth(object): @with_context @patch('pybossa.view.flickr.flickr.oauth') def test_flickr_login_specifies_callback_and_read_permissions(self, oauth): - oauth.authorize.return_value = Response(302) + oauth.authorize.return_value = "OK" flask_app.test_client().get('/flickr/') oauth.authorize.assert_called_with( callback='/flickr/oauth-authorized', perms='read') - @with_context def test_logout_removes_token_and_user_from_session(self): with flask_app.test_client() as c: @@ -46,23 +46,21 @@ def test_logout_removes_token_and_user_from_session(self): assert 'flickr_token' not in session assert 'flickr_user' not in session - @with_context @patch('pybossa.view.flickr.redirect') def test_logout_redirects_to_url_specified_by_next_param(self, redirect): - redirect.return_value = Response(302) + redirect.return_value = "OK" flask_app.test_client().get('/flickr/revoke-access?next=http://mynext_url') redirect.assert_called_with('http://mynext_url') - @with_context @patch('pybossa.view.flickr.flickr.oauth') def test_oauth_authorized_saves_token_and_user_to_session(self, oauth): fake_resp = {'oauth_token_secret': u'secret', 'username': u'palotespaco', 'fullname': u'paco palotes', - 'oauth_token':u'token', + 'oauth_token': u'token', 'user_nsid': u'user'} oauth.authorized_response.return_value = fake_resp expected_token = { @@ -77,7 +75,6 @@ def test_oauth_authorized_saves_token_and_user_to_session(self, oauth): assert session['flickr_token'] == expected_token, session['flickr_token'] assert session['flickr_user'] == expected_user, session['flickr_user'] - @with_context @patch('pybossa.view.flickr.flickr') @patch('pybossa.view.flickr.redirect') @@ -86,22 +83,21 @@ def test_oauth_authorized_redirects_to_url_next_param_on_authorization( fake_resp = {'oauth_token_secret': u'secret', 'username': u'palotespaco', 'fullname': u'paco palotes', - 'oauth_token':u'token', + 'oauth_token': u'token', 'user_nsid': u'user'} flickr.authorized_response.return_value = fake_resp - redirect.return_value = Response(302) + redirect.return_value = "OK" flask_app.test_client().get('/flickr/oauth-authorized?next=http://next') redirect.assert_called_with('http://next') - @with_context @patch('pybossa.view.flickr.flickr') @patch('pybossa.view.flickr.redirect') def test_oauth_authorized_redirects_to_url_next_param_on_user_no_authorizing( self, redirect, flickr): flickr.authorized_response.return_value = None - redirect.return_value = Response(302) + redirect.return_value = "OK" flask_app.test_client().get('/flickr/oauth-authorized?next=http://next') redirect.assert_called_with('http://next')