Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return send mail status in invitation creation api #1751

Closed
touilleMan opened this issue May 29, 2021 · 0 comments · Fixed by #1842
Closed

Return send mail status in invitation creation api #1751

touilleMan opened this issue May 29, 2021 · 0 comments · Fixed by #1842
Assignees
Labels
I-Enhancement Impact: Potential enchancement / refactor
Projects

Comments

@touilleMan
Copy link
Member

touilleMan commented May 29, 2021

When mail cannot be sent to the mailing server we get an error code that is correctly only logged:

 May 28 21:26:22 parsec-cloud-prod app/web.1 2021-05-28 19:26:22 [warning  ] SMTP error                     [parsec.backend.invite] to_addr=xxx@yyy
May 28 21:26:22 parsec-cloud-prod app/web.1     raise SMTPDataError(code, resp)
May 28 21:26:22 parsec-cloud-prod app/web.1 smtplib.SMTPDataError: (550, b'5.7.1  Reject for policy reason RULE3_2. See http://postmaster.gandi.net')
May 28 21:32:04 parsec-cloud-prod app/web.1 2021-05-28 19:32:03 [warning  ] SMTP error                     [parsec.backend.invite] to_addr=xxx@yyy
May 28 21:32:04 parsec-cloud-prod app/web.1     raise SMTPDataError(code, resp)
May 28 21:32:04 parsec-cloud-prod app/web.1 smtplib.SMTPDataError: (550, b'5.7.1  Reject for policy reason RULE3_2. See http://postmaster.gandi.net')
May 28 21:41:19 parsec-cloud-prod app/web.1 2021-05-28 19:41:19 [warning  ] SMTP error                     [parsec.backend.invite] to_addr=xxx@yyy
May 28 21:41:19 parsec-cloud-prod app/web.1     raise SMTPDataError(code, resp)
May 28 21:41:19 parsec-cloud-prod app/web.1 smtplib.SMTPDataError: (550, b'5.7.1  Reject for policy reason RULE3_2. See http://postmaster.gandi.net')

It would be better to provide this information to the client so it can inform the user the mail couldn't be send, then display the invitation link and suggest to provide it to the invitee directly.

@touilleMan touilleMan added the I-Enhancement Impact: Potential enchancement / refactor label May 29, 2021
@touilleMan touilleMan added this to New comers in Dev Board via automation May 29, 2021
@touilleMan touilleMan moved this from New comers to Investigate in Dev Board Jun 2, 2021
@Ironicbay Ironicbay moved this from Investigate to Doing in Dev Board Sep 6, 2021
@alexandrediasldev alexandrediasldev linked a pull request Sep 9, 2021 that will close this issue
@alexandrediasldev alexandrediasldev moved this from Doing to Done in Dev Board Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-Enhancement Impact: Potential enchancement / refactor
Projects
No open projects
Dev Board
To review
Development

Successfully merging a pull request may close this issue.

2 participants