godots: Update to version 1.4.1, fix checkver#17850
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the godots manifest from version 1.4 to 1.4.1, providing the new Windows 64bit download URL and SHA-256 hash for the stable release artifact. It also replaces the GitHub checkver regex pattern from Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/godots.json (1)
23-27: Run the standard Scoop manifest validation flow locally before merge.Use:
scoop config debug truescoop config gh_token <your-github-token>(optional, read-only).\bin\checkver.ps1 -App godots -f.\bin\formatjson.ps1 -App godotsscoop install bucket\godots.json -a 64bitAlso keep these handy for any manifest-rule clarifications:
- Contribution Guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- Wiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines, manifests should be locally validated with
checkver,formatjson, and architecture-specific install tests before submission.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/godots.json` around lines 23 - 27, Run the Scoop manifest validation and local install tests for the godots manifest: enable debug with `scoop config debug true`, optionally set `scoop config gh_token`, then run the provided scripts `.\bin\checkver.ps1 -App godots -f` and `.\bin\formatjson.ps1 -App godots` to validate and format autoupdate/architecture entries (see the autoupdate -> architecture -> 64bit -> url field), and finally verify installation with `scoop install bucket\godots.json -a 64bit`; fix any errors reported by these tools (version parsing in checkver, JSON formatting, or URL templating) before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/godots.json`:
- Around line 23-27: Run the Scoop manifest validation and local install tests
for the godots manifest: enable debug with `scoop config debug true`, optionally
set `scoop config gh_token`, then run the provided scripts `.\bin\checkver.ps1
-App godots -f` and `.\bin\formatjson.ps1 -App godots` to validate and format
autoupdate/architecture entries (see the autoupdate -> architecture -> 64bit ->
url field), and finally verify installation with `scoop install
bucket\godots.json -a 64bit`; fix any errors reported by these tools (version
parsing in checkver, JSON formatting, or URL templating) before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6003454a-e6cc-4f9d-801e-3b2c450445f4
📒 Files selected for processing (1)
bucket/godots.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. godots
|
Closes #17849
<manifest-name[@version]|chore>: <general summary of the pull request>