Skip to content

godots: Update to version 1.4.1, fix checkver#17850

Merged
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
shiena:fix/godots
May 21, 2026
Merged

godots: Update to version 1.4.1, fix checkver#17850
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
shiena:fix/godots

Conversation

@shiena
Copy link
Copy Markdown
Contributor

@shiena shiena commented May 21, 2026

Closes #17849

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8566187e-08b2-4fc6-8e47-c9b508478e88

📥 Commits

Reviewing files that changed from the base of the PR and between fbfbb59 and e68360a.

📒 Files selected for processing (1)
  • bucket/godots.json

📝 Walkthrough

Walkthrough

This PR updates the godots manifest from version 1.4 to 1.4.1, providing the new Windows 64bit download URL and SHA-256 hash for the stable release artifact. It also replaces the GitHub checkver regex pattern from /releases/tag/(?:v|V)?([\d.]+[\d]+) to (?:v|V)?([\d.]+[\d]+)\.stable to enable automatic version detection for stable tags published by the godots project, resolving a checkver failure preventing auto-updates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • ScoopInstaller/Extras#16841: Updates checkver regex patterns in multiple manifests to parse GitHub tags correctly, including similar stable-tag regex changes to other packages in the bucket.
  • ScoopInstaller/Extras#16784: Updates checkver/tag-parsing logic and URL templating to correctly extract versions from GitHub release tags for other manifests.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: updating godots to version 1.4.1 and fixing the checkver regex pattern.
Description check ✅ Passed The description includes the required checklist items marked as complete and properly references the linked issue #17849.
Linked Issues check ✅ Passed The PR successfully addresses all coding requirements from issue #17849: updates version to 1.4.1, fixes checkver regex to match GitHub API tag_name format, and updates the autoupdate URL accordingly.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue #17849; the PR only modifies bucket/godots.json to update version and fix checkver logic as required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/godots.json (1)

23-27: Run the standard Scoop manifest validation flow locally before merge.

Use:

  • scoop config debug true
  • scoop config gh_token <your-github-token> (optional, read-only)
  • .\bin\checkver.ps1 -App godots -f
  • .\bin\formatjson.ps1 -App godots
  • scoop install bucket\godots.json -a 64bit

Also keep these handy for any manifest-rule clarifications:

As per coding guidelines, manifests should be locally validated with checkver, formatjson, and architecture-specific install tests before submission.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/godots.json` around lines 23 - 27, Run the Scoop manifest validation
and local install tests for the godots manifest: enable debug with `scoop config
debug true`, optionally set `scoop config gh_token`, then run the provided
scripts `.\bin\checkver.ps1 -App godots -f` and `.\bin\formatjson.ps1 -App
godots` to validate and format autoupdate/architecture entries (see the
autoupdate -> architecture -> 64bit -> url field), and finally verify
installation with `scoop install bucket\godots.json -a 64bit`; fix any errors
reported by these tools (version parsing in checkver, JSON formatting, or URL
templating) before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/godots.json`:
- Around line 23-27: Run the Scoop manifest validation and local install tests
for the godots manifest: enable debug with `scoop config debug true`, optionally
set `scoop config gh_token`, then run the provided scripts `.\bin\checkver.ps1
-App godots -f` and `.\bin\formatjson.ps1 -App godots` to validate and format
autoupdate/architecture entries (see the autoupdate -> architecture -> 64bit ->
url field), and finally verify installation with `scoop install
bucket\godots.json -a 64bit`; fix any errors reported by these tools (version
parsing in checkver, JSON formatting, or URL templating) before merging.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6003454a-e6cc-4f9d-801e-3b2c450445f4

📥 Commits

Reviewing files that changed from the base of the PR and between c061a25 and fbfbb59.

📒 Files selected for processing (1)
  • bucket/godots.json

@z-Fng z-Fng changed the title godots: Update to version 1.4.1, fix autoupdate godots: Update to version 1.4.1, fix checkver May 21, 2026
@z-Fng
Copy link
Copy Markdown
Member

z-Fng commented May 21, 2026

/verify

@github-actions
Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

godots

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Copy Markdown
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 60ad13a into ScoopInstaller:master May 21, 2026
3 checks passed
@shiena shiena deleted the fix/godots branch May 21, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: godots failing to update

2 participants