This repository has been archived by the owner on Apr 20, 2020. It is now read-only.
.Net Standard, Minecraft query support. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Thank you very much for adding this, I'm sure a lot of people will be very appreciative as well 👍 I'm a junior dev myself, but I'd just like to say that your code looks great. Your changes are now available in version 3.0.0. |
|
The project is now licensed under MIT per #9 - hopefully this is alright with you @CodingContraption . If not, please let me know and we can figure something out. |
|
No problem at all, don't worry about it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
To be able to use this library for minecraft (query was not compatible) I have made some changes to add support for minecraft queries.
In the process I also changed the solution to csproj and converted the project to .NET Standard 1.6.
I understand my changes are quite radical, feedback is welcome since I am still a junior developer.