Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot: AddMarker() #1391

Closed
swharden opened this issue Oct 21, 2021 · 4 comments · Fixed by #1404
Closed

Plot: AddMarker() #1391

swharden opened this issue Oct 21, 2021 · 4 comments · Fixed by #1404
Assignees

Comments

@swharden
Copy link
Member

It would be helpful to be able to Plot.AddMarker() or something similar to place a circle or square or other marker at a specific point on the plot. It could be a pass-through to Plot.AddPoint()

@bclehmann
Copy link
Member

I think this is pretty redundant as AddPoint already exists and it takes a MarkerShape parameter. I think the idea is to simplify it in the case where you want a specific marker shape, but I don't think AddPoint is complicated as it is.

@swharden
Copy link
Member Author

@bclehmann I agree with you it's redundant and AddPoint isn't complicated... but the other day I wanted to add a marker to the plot at an X/Y location and I struggled to figure out how it could be done. My thought is that a top-level method with Marker in its name would make this more discoverable... so my motivation here is more for documentation purposes.

@bclehmann
Copy link
Member

Would duplicating the method with a view to remove AddPoint in a later release help?

But even then, I think in a lot of cases adding a point to a plot is the more intuitive way to phrase the same thing.

@swharden
Copy link
Member Author

swharden commented Oct 23, 2021

I think there's room for both AddPoint and AddMarker even though they both do the same thing, because if you want to add a dot you might use intelligence IntelliSense to reach for the former, but if you want to add a square or triangle you may reach for the latter.

Naming things is hard 🙃

swharden added a commit that referenced this issue Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants