Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caching openmpi, .julia, rm Simulation #21

Merged
merged 38 commits into from
May 7, 2020
Merged

caching openmpi, .julia, rm Simulation #21

merged 38 commits into from
May 7, 2020

Conversation

jwscook
Copy link

@jwscook jwscook commented May 4, 2020

This might well speed up travis, but will have to run travis twice to find out.

@jwscook jwscook requested a review from a team May 4, 2020 16:09
jwscook and others added 28 commits May 5, 2020 08:59
SCRC-87 

See failure https://travis-ci.org/github/ScottishCovidResponse/Simulation.jl/jobs/683003127
Julia tries to "Activating new environment at `~/build/ScottishCovidResponse/Simulation.jl/openmpi/Project.toml`" - openmpi is in the wrong place for caching
SCRC-87

Should have gone in with previous commit to this branch
SCRC-87

ERROR: LoadError: LoadError: InitError: could not load library "/home/travis/build/ScottishCovidResponse/Simulation.jl/openmpi/lib/libmpi"
which isn't where openmpi should be - should be in ~
SCRC-87
print statements at top of test/runtests.jl that need to be removed eventually
print statements in .travis.yml ""
SCRC-87 caching openmpi dir, and moving it into the JULIA_PROJECT path at the start of the travis script
SCRC-87 caching openmpi dir, and moving openmpi dir to cache
SCRC-87 ERROR: LoadError: LoadError: InitError: MPI library has changed, please restart Julia. was copying mpi stuff into Simulation.jl, now setting JULIA_MPI_PATH
SCRC-87 wasnt checking in right palce for mpirun
SCRC-87 was only deleting the .julia/packages/Simulation.jl after_success and not after_success. now done in before_cache:. Can't do it in after_script because that happens after cache:.
SCRC-87 had ./openmpi not ~/openmpi
SCRC-87 good old print statements
SCRC-87 working on installMPI.sh for macosx, trying to get it to recognise the cached directory /usr/local/Cellar
SCRC-87 working on installMPI.sh for macosx, trying to get it to recognise the cached directory /usr/local/Cellar
SCRC-87 working on installMPI.sh for macosx, got wrong path to mpi installation under Cellar
SCRC-87 need to set PATH and LD_LIBRARY_PATH
SCRC-87 set DYLD_LIBRARY_PATH not LD_LIBRARY_PATH
SCRC-87 might need to manually set DYLD_LIBRARY_PATH now attempting to relink with brew
Copy link

@claireh93 claireh93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi James, I have lost track a bit, is this ready to be merged?

SCRC-87 trying different install path so maybe fewer symlinks to deal with?
@codecov-io
Copy link

codecov-io commented May 6, 2020

Codecov Report

Merging #21 into dev will increase coverage by 2.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #21      +/-   ##
==========================================
+ Coverage   26.89%   29.29%   +2.39%     
==========================================
  Files          46       46              
  Lines        2506     2550      +44     
==========================================
+ Hits          674      747      +73     
+ Misses       1832     1803      -29     
Impacted Files Coverage Δ
src/Simulation.jl 100.00% <ø> (ø)
src/Epidemiology/EpiGenerate.jl 56.83% <100.00%> (+0.31%) ⬆️
src/Epidemiology/EpiList.jl 71.42% <100.00%> (+39.84%) ⬆️
src/Epidemiology/EpiParams.jl 100.00% <100.00%> (+65.71%) ⬆️
src/Biodiversity/Habitats.jl 42.26% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2febb6d...862033c. Read the comment docs.

@jwscook
Copy link
Author

jwscook commented May 7, 2020

Not ready yet I'm afraid :(

@jwscook jwscook marked this pull request as draft May 7, 2020 08:12
Cook, James added 4 commits May 7, 2020 09:18
SCRC-87 travis says /Users/travis/openmpi is brought out of cache, yet ls reveals nothing
@claireh93
Copy link

No worries! Sorry I was just going through open PRs last night, but now with my brain switched on I see you need to run travis twice on these commits

Cook, James added 3 commits May 7, 2020 11:23
SCRC-87 speeding up unlink link by passing hw.ncpu to xargs via -P argument
SCRC-87 need to rebuild cellar from scratch, then use a new cached version
SCRC-87 use cached cellar, repair symlinks
@jwscook jwscook marked this pull request as ready for review May 7, 2020 16:57
@jwscook jwscook requested review from a team and removed request for a team May 7, 2020 16:58
SCRC-87 it was in .travis.yml but makes more sense in installMPI.sh
@jwscook jwscook merged commit 9148359 into dev May 7, 2020
@jwscook jwscook deleted the jwscook/traviscache branch June 8, 2020 16:33
richardreeve pushed a commit that referenced this pull request Apr 21, 2021
…12-04-08-30-704-3078825718

CompatHelper: bump compat for "Plots" to "1.11"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants