Skip to content

Highlight block addon causing lots of lag #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeffalo opened this issue Sep 27, 2020 · 5 comments · Fixed by #652
Closed

Highlight block addon causing lots of lag #336

jeffalo opened this issue Sep 27, 2020 · 5 comments · Fixed by #652
Labels
type: bug A bug in the addon loader, or in a specific addon
Milestone
v1.3.0

Comments

@jeffalo
Copy link
Contributor

jeffalo commented Sep 27, 2020 •
edited
Loading

Describe the bug

when using the addon that highlights the active block, the project lags

To Reproduce

  1. enable addon
  2. open the editor in a project with a lot of blocks (it's fairly noticeable here)

Expected behavior

the highlight blocks addon does not make projects lag

Device (please complete the following information):

windows 10/chrome

Additional context

I've seen this bug reported a lot in the feedback, with different OSs
@jeffalo jeffalo added the type: bug A bug in the addon loader, or in a specific addon label Sep 27, 2020
@jeffalo
Copy link
Contributor Author

jeffalo commented Sep 27, 2020

i also don't think the addon works, or i dont really know what its supposed to do.

@WorldLanguages
Copy link
Member

It appeared to work for me.

@WorldLanguages WorldLanguages added this to the v1.0.1 milestone Sep 27, 2020
@WorldLanguages
Copy link
Member

It might not be possible to avoid lag all together - if it's not possible, this issue will turn out as a "warn users about it".

@Hans5958 Hans5958 pinned this issue Sep 28, 2020
@Hans5958 Hans5958 unpinned this issue Sep 28, 2020
@Hans5958
Copy link
Member

Hans5958 commented Sep 29, 2020 •
edited
Loading

Related: #345

@WorldLanguages WorldLanguages modified the milestones: v1.1, v1.2 Oct 7, 2020
@WorldLanguages
Copy link
Member

Related: #431
Note that it appears that the way this addon is coded, plus the traps, both hurt performance and create a double combo of lag.

@WorldLanguages WorldLanguages modified the milestones: v1.2, v1.3 Oct 22, 2020
@WorldLanguages WorldLanguages mentioned this issue Nov 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A bug in the addon loader, or in a specific addon
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

Remove prototype handler, add /* sa-autoupdate-theme-ignore */ WorldLanguages/ScratchAddons
3 participants
@Hans5958 @WorldLanguages @jeffalo