Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter prototype handler for addon.tab.traps API #431

Closed
WorldLanguages opened this issue Oct 7, 2020 · 0 comments · Fixed by #652
Closed

Smarter prototype handler for addon.tab.traps API #431

WorldLanguages opened this issue Oct 7, 2020 · 0 comments · Fixed by #652
Labels
type: enhancement New feature for the project
Milestone

Comments

@WorldLanguages
Copy link
Member

The current prototype handler hurts project performance and it's been reported it causes memory leaks. Let's require addons to specify in the manifest what types of traps they'll use, store in local storage (this is already being done now, but with a boolean, aka "I'm using traps", to avoid performance issues if the user doesn't need traps) with the already existing system to do so.

cc @apple502j

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature for the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant