Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fix-buttons #506

Merged
merged 2 commits into from Oct 22, 2020
Merged

Remove fix-buttons #506

merged 2 commits into from Oct 22, 2020

Conversation

Hans5958
Copy link
Member

This is just a simple PR to resolve #501.

@WorldLanguages
Copy link
Member

I should make sure nothing terrible happens if an addon gets removed, hasn't happened until now

@WorldLanguages
Copy link
Member

Whoops, looks like the fix-buttons manifest was changed because of the new camelCase properties, so now there's a conflict. Just tested and scratch-www hasn't been updated on production. To avoid further conflicts (specially in addons.json, the king of conflicts) let's close this PR for now

@Hans5958 Hans5958 reopened this Oct 22, 2020
@WorldLanguages WorldLanguages merged commit c5af49d into ScratchAddons:master Oct 22, 2020
@Explosion-Scratch Explosion-Scratch mentioned this pull request Oct 22, 2020
Closed
@Hans5958 Hans5958 deleted the remove-fix-buttons branch October 27, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "Load more" fix can be removed soon
2 participants
@Hans5958 @WorldLanguages