Icons Galore - Mass Icon Unification

[ZenithRogue]

Resolves

This massive update resolves an issue @WorldLanguages brought up in #573, and updates Scratch Notifier to use svg icons consistent with the new icons found in the messaging pop-up.

This is nice - I just think it's worth discussing if we're ok with inconsistency with Scratch Notifier? For obvious reasons, Scratch Notifier can only use OS level emojis, so we end up with 2 different sets of icons for the same message.

Originally posted by @WorldLanguages in #573 (comment)

This did involve a bit of a formatting change, but I believe it is well worth it.

The ScratchAddons logo has instead been replaced by the SVG icon appropriate to the notification type, rather than embedding an emoji.

Changes

As shown above, the notification messages have been changed for consistency, but there are also another small changes:

• All svg icons used for the settings/pop-up pages have been moved to a central location: images/icons

• Addons can now use icons inline with their setting names Example text @heart.svg owo which is parsed, and rendered as:
  
  Large scale example:
  

Reason for changes

They are pretty 🔥 ngl

Tests

Everything has been extensively tested.

I've ironed out all the bugs, and I have ensured that all previous icon references have been moved to the proper icon location.

[GrahamSH-LLK]

One thing that might be cool would be to overlay the ScratchAddons logo in the corner of the notification icon.

[retronbv]

how do they look on other os's (is that even the right word?) like chromebook, or mac

[ZenithRogue]

This should obviously be merged after #573 btw

[ZenithRogue]

One thing that might be cool would be to overlay the ScratchAddons logo in the corner of the notification icon.

That would be cool in concept, but unfortunately, it just doesn't look very good.

Also, it would be a big ramp in how technically demanding it is.
I would either need to write code to pull each of the images, combine them together, and pass the base64 representation to the notification (which, im not even sure is possible)
Or combine all of the icons manually, and keep them as seperate files, defeating the purpose of the icon unification entirely

[ZenithRogue]

how do they look on other os's (is that even the right word?) like chromebook, or mac

I do not have a mac, so i have no idea tbh

I will check it out on my chromebook shortly tho

[WorldLanguages]

I'll soon add the word "Scratch Addons" to the notification so that it's clear it comes from it

[WorldLanguages]

I will check it out on my chromebook shortly tho

You don't need a chromebook, just go to chrome://flags and disable native notifications

[Explosion-Scratch]

I'll take a look! I use a chromebook, otherwise it looks great!

…

On Sat, Oct 31, 2020 at 9:43 AM Bill Shoener ***@***.***> wrote: how do they look on other os's (is that even the right word?) like chromebook, or mac I do not have a mac, so i have no idea tbh — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#617 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOT2P3UFLA3KUPE6GVQEH3LSNQPC7ANCNFSM4TFW7TXA> .

[Explosion-Scratch]

I meant about the icons. Anyways: https://user-images.githubusercontent.com/61319150/97783446-d38fde00-1b65-11eb-878a-cef2adbedfbd.png

…

On Sat, Oct 31, 2020 at 10:39 AM World_Languages ***@***.***> wrote: I will check it out on my chromebook shortly tho You don't need a chromebook, just go to chrome://flags and disable native notifications — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#617 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOT2P3RQPKWEMOCAAZKAD7LSNQVSZANCNFSM4TFW7TXA> .