Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons Galore - Mass Icon Unification #617

Merged
merged 12 commits into from Nov 1, 2020

Conversation

ZenithRogue
Copy link
Contributor

Resolves

This massive update resolves an issue @WorldLanguages brought up in #573, and updates Scratch Notifier to use svg icons consistent with the new icons found in the messaging pop-up.

This is nice - I just think it's worth discussing if we're ok with inconsistency with Scratch Notifier? For obvious reasons, Scratch Notifier can only use OS level emojis, so we end up with 2 different sets of icons for the same message.

Originally posted by @WorldLanguages in #573 (comment)

This did involve a bit of a formatting change, but I believe it is well worth it.

The ScratchAddons logo has instead been replaced by the SVG icon appropriate to the notification type, rather than embedding an emoji.
image
image

Changes

As shown above, the notification messages have been changed for consistency, but there are also another small changes:

  • All svg icons used for the settings/pop-up pages have been moved to a central location: images/icons

  • Addons can now use icons inline with their setting names Example text @heart.svg owo which is parsed, and rendered as:
    image
    Large scale example:
    image

Reason for changes

They are pretty 馃敟 ngl

Tests

Everything has been extensively tested.

I've ironed out all the bugs, and I have ensured that all previous icon references have been moved to the proper icon location.

@GrahamSH-LLK
Copy link
Member

One thing that might be cool would be to overlay the ScratchAddons logo in the corner of the notification icon.

@retronbv
Copy link
Contributor

how do they look on other os's (is that even the right word?) like chromebook, or mac

@ZenithRogue
Copy link
Contributor Author

This should obviously be merged after #573 btw

@ZenithRogue
Copy link
Contributor Author

One thing that might be cool would be to overlay the ScratchAddons logo in the corner of the notification icon.

That would be cool in concept, but unfortunately, it just doesn't look very good.

Also, it would be a big ramp in how technically demanding it is.
I would either need to write code to pull each of the images, combine them together, and pass the base64 representation to the notification (which, im not even sure is possible)
Or combine all of the icons manually, and keep them as seperate files, defeating the purpose of the icon unification entirely

@ZenithRogue
Copy link
Contributor Author

ZenithRogue commented Oct 31, 2020

how do they look on other os's (is that even the right word?) like chromebook, or mac

I do not have a mac, so i have no idea tbh

I will check it out on my chromebook shortly tho

@WorldLanguages
Copy link
Member

I'll soon add the word "Scratch Addons" to the notification so that it's clear it comes from it

@WorldLanguages
Copy link
Member

I will check it out on my chromebook shortly tho

You don't need a chromebook, just go to chrome://flags and disable native notifications

@Explosion-Scratch
Copy link
Contributor

Explosion-Scratch commented Oct 31, 2020 via email

@Explosion-Scratch
Copy link
Contributor

Explosion-Scratch commented Oct 31, 2020 via email

@WorldLanguages WorldLanguages merged commit b93c33f into ScratchAddons:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants