fix(server): log GitHub release-check failures at warning, not error#3019
Merged
Conversation
- A device that can't reach api.github.com (offline installs, locked-down networks, GitHub outages, rate limits) is a routine condition the update check already degrades through gracefully: 5-minute backoff plus the cached last verdict - ERROR-level logs land in Sentry, so every offline device produced events on each splash-page render (Sentry ANTHIAS-8) - Downgrade every failure path in lib/github.py to warning and pin the module as ERROR-free with a regression test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces Sentry noise from routine GitHub connectivity/update-check failures by downgrading anthias_server.lib.github logging from ERROR to WARNING, and adds regression tests to prevent error-level logging from being reintroduced.
Changes:
- Downgraded GitHub update-check failure logs in
src/anthias_server/lib/github.pyfromlogging.error(...)tologging.warning(...). - Added a unit test verifying
handle_github_error()logs at WARNING (not ERROR). - Added a “no error-level logging” regression test for the
githubmodule.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/anthias_server/lib/github.py |
Downgrades GitHub update-check failure logging from ERROR to WARNING across multiple failure paths. |
tests/test_github.py |
Adds regression tests to ensure GitHub failures don’t log at ERROR level (to avoid Sentry events). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ging - Replace the brittle substring check with an AST walk over actual logging.* calls, so comments can't false-positive and ERROR-level calls can't slip through renamed (Copilot) - Patch logging by dotted path for strict mypy Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…docstring Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ST guard Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This was referenced Jun 7, 2026
Open
vpetersson
added a commit
that referenced
this pull request
Jun 9, 2026
- CalVer (YYYY.0M.MICRO); still June 2026, micro 2 -> 3 - Gives Sentry a real release boundary: every build since 2026.6.2 reported the same base version (only the +git-hash differed), so resolved-in-next-release never stuck and fixed issues kept reopening on the next event. A version bump lets the deployed fixes actually clear from the board. - Ships the crash/noise fixes merged since 2026.6.2: SQLite WAL + busy timeout (#3015), celery migration-gate (#3016) and asset-probe soft limits (#3017), transient-redis/CancelledError Sentry filtering + redis healthcheck (#3018/#3028), GitHub update-check log level (#3019), webview respawn on D-Bus death at setup and mid-play (#3020/#3031), resilient static-file scan (#3026), Wayland-socket wait (#3030), and Sentry release/board triage tags (#3021/#3025) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vpetersson
added a commit
that referenced
this pull request
Jun 9, 2026
…ings (#3023) - A bare 'no data' hid the host/timeout info str(exc) carries — Sentry ANTHIAS-8 read 'ConnectionError fetching latest release from GitHub: no data', which said nothing actionable - Ported from #3014 (the rest of that PR shipped via #3019) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Sentry: ANTHIAS-8 (
ConnectionError fetching latest release from GitHub: no dataon/splash-page/).Description
A signage device that can't reach
api.github.com— offline installs, locked-down networks, GitHub outages, rate limits — is a routine condition, and the update check already degrades through it gracefully (5-minute error backoff, cached last verdict inis_up_to_date()). But the failure paths logged at ERROR, which the Sentry logging integration turns into an event, so every offline device reported on each splash-page render.lib/github.py(transport errors, malformed/missing/unparseabletag_name) to WARNINGhandle_github_errorChecklist
🤖 Generated with Claude Code