Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to specify the ip address for the device in screenly. … #885

Closed
wants to merge 9 commits into from

Conversation

Projects
None yet
4 participants
@jishac
Copy link

commented Aug 23, 2018

…This allows screenly to be used in "offline" mode.

p-rintz and others added some commits Mar 2, 2018

Make ipv6-only setups work
Change get_node_ip to also work with ipv6-only setups.
Changed to use netifaces.gateways
Instead of netstat and grep, netifaces.gateways will now be used to find out the default gateway.
IPv6 prefferance
my_ip no longer uses min() to select the interface.
the usage of max() in interface_id should be unproblematic though and would lead to ipv6 being preferred over ipv4 when available.

Should also be more readable now, while maybe still being more verbose than wanted, though?
netifaces import change
As requested in comments.
Allow the user to specify the ip address for the device in screenly. …
…This allows screenly to be used in "offline" mode.
@jishac

This comment has been minimized.

Copy link
Author

commented Aug 23, 2018

Screenly is intended to work in an "offline" mode according to https://support.screenly.io/hc/en-us/articles/115002570873-Can-I-use-Screenly-OSE-in-offline-mode-

Screenly's hotspot can be disabled by creating the file .screenly/initialized and the network interfaces manually configured for local access.

However, the system will not operate without a default gateway set. This small modification is intended to allow the user to specify a local address as the one to use for the device. No checks are made against the user supplied address.

Renamed variable
Renamed interface_id to address_family_id
@antonmolodykh

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

I don't quite understand why this is necessary. I mean that in fact, if there is no default gateway, you see "Unable to resolve local IP address." on your screen, and after that Screenly works as usual, that is, it displays local content. right?

Merge pull request #756 from p-rintz/patch-1
Make ipv6-only setups work
@jishac

This comment has been minimized.

Copy link
Author

commented Aug 24, 2018

It did not move past the splash screen, and more importantly I was unable to access the screenly web API to manage or upload content. I would get a 500 error from the server.

jishac added some commits Aug 23, 2018

Allow the user to specify the ip address for the device in screenly. …
…This allows screenly to be used in "offline" mode.
Rebased to HEAD, lib/utils.py merged
Merge branch 'offline_support' of github.com:jishac/screenly-ose into offline_support
@antonmolodykh

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

It did not move past the splash screen

this is because there are no local assets in your playlist (that is, the playlist is not empty, but all assets are web pages)

I would get a 500 error from the server.

I'm not sure that this is so. the server must be started in any case. I'll check it out again tomorrow, but I'm sure it's true.
anyway, in my opinion your PR makes sense, but I can't decide how good this idea is. What do you think, @vpetersson ?

@stale

This comment has been minimized.

Copy link

commented Oct 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 23, 2018

@stale stale bot closed this Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.