Drop the Sized requirement on implementers of SchemaBuilders #524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm implementing a dynamic query builder that just dispatches to either of Sqlite/Mysql/PostgresQueryBuilder dynamically, so I have an internal function returning a
&dyn GenericBuilder
. This works to implement (delegate) all the functions, except forprepare_column_spec
that has aSized
requirement.Here we move the
QueryBuilder
requirement to the trait instead of the function, allowing us to get rid ofSized
.