Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the Sized requirement on implementers of SchemaBuilders #524

Merged
merged 1 commit into from Nov 25, 2022

Conversation

nitnelave
Copy link
Contributor

I'm implementing a dynamic query builder that just dispatches to either of Sqlite/Mysql/PostgresQueryBuilder dynamically, so I have an internal function returning a &dyn GenericBuilder. This works to implement (delegate) all the functions, except for prepare_column_spec that has a Sized requirement.

Here we move the QueryBuilder requirement to the trait instead of the function, allowing us to get rid of Sized.

@nitnelave
Copy link
Contributor Author

Actually, I can make do with build_any, so I don't need this PR. I still think it's useful, but up to you.

Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitnelave thank you! LGTM!

@ikrivosheev ikrivosheev merged commit 31edae6 into SeaQL:master Nov 25, 2022
@tyt2y3
Copy link
Member

tyt2y3 commented Nov 28, 2022

Interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants