Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup a rust-toolchain file #643

Closed
wants to merge 1 commit into from

Conversation

LeoBorai
Copy link
Contributor

@LeoBorai LeoBorai commented Jun 4, 2023

In order to share the same Rust version a rust-toolchain file is provided, cargo will automatically fetch and use the specified toolchain.

@LeoBorai LeoBorai force-pushed the feat/rust-toolchain branch from 95f47de to 0d74755 Compare June 4, 2023 00:27
@LeoBorai
Copy link
Contributor Author

LeoBorai commented Jun 4, 2023

Clippy issues fixed on: #644

In order to share the same Rust version a `rust-toolchain` file
is provided, `cargo` will automatically fetch and huse the specified
toolchain.
@LeoBorai LeoBorai force-pushed the feat/rust-toolchain branch from 0d74755 to 499f7ad Compare June 4, 2023 22:16
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not pinning the nightly version. Staying up-to-date seems a better idea to me.

@LeoBorai
Copy link
Contributor Author

LeoBorai commented Jun 6, 2023

I would prefer not pinning the nightly version. Staying up-to-date seems a better idea to me.

Agree! I wonder if theres a way to use nightly by default in this repo when using cargo 🤔

@LeoBorai
Copy link
Contributor Author

LeoBorai commented Jun 6, 2023

@billy1624 will open another PR if I find a way! Thanks!

@LeoBorai LeoBorai closed this Jun 6, 2023
@LeoBorai LeoBorai deleted the feat/rust-toolchain branch June 6, 2023 15:09
@billy1624
Copy link
Member

Thanks for the efforts! @EstebanBorai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants