Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format and clean code #5

Merged
merged 5 commits into from
Dec 5, 2022
Merged

Format and clean code #5

merged 5 commits into from
Dec 5, 2022

Conversation

thilinarmtb
Copy link
Contributor

No description provided.

@nchristensen
Copy link
Contributor

Is this from running autopep8?

@thilinarmtb
Copy link
Contributor Author 

black -l 80 *.py */*.py */*/*.py`

followed by

isort *.py */*.py */*/*.py

@thilinarmtb
Copy link
Contributor Author

There are a lot of flake8 failures. Probably need to be fixed before merging this.

@thilinarmtb thilinarmtb changed the title Format code Format and clean code Sep 30, 2022
@thilinarmtb
Copy link
Contributor Author

What is with the no_install directory? Seems redundant.

@nchristensen
Copy link
Contributor

Yeah we can probably resolve most of them by running autopep8 on all of the .py files like here.

@nchristensen
Copy link
Contributor

We should probably set up CI at some point too.

@thilinarmtb
Copy link
Contributor Author

@nchristensen : Remaining flake8 errors are mainly related to loopy kernels. Can you clean it up?

@nchristensen nchristensen mentioned this pull request Dec 5, 2022
Closed
nchristensen
nchristensen approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@nchristensen nchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nchristensen nchristensen merged commit 53f0aef into master Dec 5, 2022
@nchristensen nchristensen deleted the format_code branch December 5, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchristensen nchristensen nchristensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thilinarmtb @nchristensen