Sean DuBois Sean-Der

Organizations

@etsy @HackerSchool12
@Sean-Der
  • @Sean-Der 0ecf768
    Finish 'unpack of template convertor' test fails, memory leaks unfixed
@Sean-Der
  • @Sean-Der a171470
    Finish 'unpack of template convertor' test fails, memory leaks unfixed
  • @Sean-Der c51a499
    Fix unpacking code, we can't just reuse the stack anymore since the z…
  • 5 more commits »
Sean-Der commented on pull request msgpack/msgpack-php#48
@Sean-Der

Hey @laruence, first off good news! We are at 85% with test fails, holy crap I never thought I would see the day.... https://gist.github.com/Sean-D…

@Sean-Der
  • @Sean-Der 3fb45c3
    Z_LVAL_P on a boolean is no longer valid, msgpack->setOption incorrec…
Sean-Der commented on pull request msgpack/msgpack-php#48
@Sean-Der

@laruence I am at 55.0% on test fails, getting there! However, I am confused about the behavior of printing references in 5 vs 7. Here is a gist o…

@Sean-Der
  • @Sean-Der b1a2abc
    Update MessagePackUnpacker to use new object API, fixing unpacker tests
@Sean-Der
  • @Sean-Der f53f484
    Remove MSGPACK_METHOD1 macro which created the necessary opcodes to c…
@Sean-Der
@Sean-Der
  • @Sean-Der 676e6bd
    Update msgpack_unserialize_map_item to remove accidently added Z_ISREF_P
@Sean-Der
  • @Sean-Der 3a75af1
    Cleaner ref handling when unpacking a map item
@Sean-Der
  • @Sean-Der 7842d8c
    Cleaner ref handling when unpacking a map item
Sean-Der commented on pull request msgpack/msgpack-php#48
@Sean-Der

This macro feels pointless, but I couldn't find a way to implement this functionality without a lot of extra code

Sean-Der commented on pull request msgpack/msgpack-php#48
@Sean-Der

Calling zend_symtable_update on the HASH_OF a class breaks the class in PHP 7. Later when trying to modify the class you can't access members added…

Sean-Der commented on pull request msgpack/msgpack-php#48
@Sean-Der

@laruence What is the proper way to ZVAL_DEREF *container here, without actually modifying *container? Calling array_init on the result of Z_REFVA…

Sean-Der commented on issue msgpack/msgpack-php#36
@Sean-Der

Hey everyone, I am working on PHPNG support in PR #48 I would love to get v5 support into that branch! I will not be working on until I get all th…

@Sean-Der
  • @Sean-Der caa80cb
    Use Z_OBJCE_P instead of Z_OBJ_P()->ce
@Sean-Der
@Sean-Der
  • @Sean-Der 210da3d
    In msgpack_serialize_object allocate strings later, to make error han…
Sean-Der opened pull request msgpack/msgpack-php#48
@Sean-Der
PHP7 Support
54 commits with 705 additions and 1,312 deletions
@Sean-Der
  • @Sean-Der 2247ba1
    Fix memory leak in msgpack_unserialize_map_item when executing __wakeup
@Sean-Der
  • @Sean-Der 351c29c
    Fix zend_string memory leak in msgpack_serialize_class
@Sean-Der
  • @Sean-Der 93ec0c7
    Fix pack/unpack memory leaks for classes
@Sean-Der
  • @Sean-Der 1185dba
    Fix memory leaks for non-dtor allocations
@Sean-Der
  • @Sean-Der a40f0e7
    Fix memory leak, don't make pointless dupe of zval string when updati…
@Sean-Der
  • @Sean-Der b265cd9
    Bring back seperate stacks for dtor variables, still emalloc leaks
@Sean-Der
Running fail2ban 0.9.:
Sean-Der commented on issue Sean-Der/fail2rest#17
@Sean-Der

Hey @datiti ! thanks for reporting this, I will create a VM tonight with the same environment and see if I can reproduce. If I can't I will get to…

@Sean-Der
  • @Sean-Der 308e918
    msgpack_serialize_object is now ref aware
@Sean-Der
  • @Sean-Der 60a3044
    Bring back serializable interface support, was behind IFDEFs
@Sean-Der
  • @Sean-Der 94d6f04
    MSGPACK_UNPACK_CONTINUE returned from template_execute means we shoul…