fix: improve BLE reliability across macOS, Windows, and Linux#1
Merged
Conversation
…logic Fix idle reconnect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses unreliable Bluetooth Low Energy device discovery and connection stability caused by Bleak's static
BleakScannermethods on macOS CoreBluetooth, as well as metrics not updating correctly after pause/resume cycles. Fixes are cross-platform compatible.Changes
Device Discovery & Connection
BleakScannermethods withasync with BleakScanner()context manager — more stable on macOS CoreBluetooth and consistent across all platformsBLE_DEVICE_NAMEconstant at top ofapp.py— no scanner logic changes neededEvent Loop & Task Management
_stats_monitor_tasktracks the active monitor; old tasks are cancelled before new ones on resume, cleaned up on disconnect. Fixes metrics-not-updating-after-pause/resume bugasyncio.wait_for()with 2s timeout on stats polling prevents hangingError Handling
start_belt(),resume_session()) — failures properly update app state and trigger disconnect handling instead of leaving the app in a hung staterun_coroutine_threadsafe()calls ensures proper state management if queueing failsAPI Compatibility
set_disconn_callback()(newer) andset_disconnected_callback()(older), ensuring compatibility across Bleak 0.19+Compatibility
Testing Recommendations