Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis config to use latest wkhtmltopdf RC #16

Merged
merged 1 commit into from Jun 1, 2018
Merged

Conversation

0xhaven
Copy link
Contributor

@0xhaven 0xhaven commented Jun 1, 2018

We needed to do this to avoid this issue: wkhtmltopdf/wkhtmltopdf#3001 based on @ashkulz suggestion.

@codecov-io
Copy link

codecov-io commented Jun 1, 2018

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files           3        3           
  Lines         450      450           
=======================================
  Hits          411      411           
  Misses         25       25           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ae52a...253db0b. Read the comment docs.

@SebastiaanKlippert SebastiaanKlippert merged commit 5d2b2cf into SebastiaanKlippert:master Jun 1, 2018
@SebastiaanKlippert
Copy link
Owner

Thanks for the quick update!

@ashkulz
Copy link

ashkulz commented Jun 1, 2018

Please note that the rc builds will be removed from the current location after the final release (which will be hosted at Github).

@SebastiaanKlippert
Copy link
Owner

Thanks for the reminder @ashkulz
I will update after the latest release.

@ashkulz
Copy link

ashkulz commented Jun 12, 2018

0.12.5 has been released and -rc builds have been removed, please take updated URL from https://wkhtmltopdf.org/downloads.html#stable

@SebastiaanKlippert
Copy link
Owner

Thanks, been looking at your releases and waiting for the builds

@ashkulz
Copy link

ashkulz commented Jun 13, 2018

Yeah, had to redo them because of a limitation in Github. It takes ~16 hours to build for all platforms, so it took time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants