Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level Music Keeps Playing While Death Music Plays #672

Closed
datahead8888 opened this issue Dec 11, 2019 · 3 comments
Closed

Level Music Keeps Playing While Death Music Plays #672

datahead8888 opened this issue Dec 11, 2019 · 3 comments

Comments

@datahead8888
Copy link
Member

@datahead8888 datahead8888 commented Dec 11, 2019

I noticed that if you die in a level, the level music already playing keeps playing while the death music begins playing. I do not remember this behavior before -- it is traditional in games only to play the death music during death.

@Quintus

This comment has been minimized.

Copy link
Member

@Quintus Quintus commented Dec 12, 2019

Actually, this is intentional. In cLevel_Player::DownGrade_Plyer() the background music is faded out slowly, and not stopped immediately. The fadeout time is set to about the duration of the death animation.

@Quintus Quintus added the Feature label Dec 12, 2019
@refi64

This comment has been minimized.

Copy link
Member

@refi64 refi64 commented Dec 16, 2019

I kinda feel like it would be nicer if this either:

  • Cuts out.
  • Fades the game music but doesn't play the death music.

Right now with both it just seems weird...

@Quintus

This comment has been minimized.

Copy link
Member

@Quintus Quintus commented Dec 16, 2019

Appearently the majority opinion is that the music should be stopped. I add this to the 2.1.0 milestone so it will become part of the 2.1.0 release...

@Quintus Quintus added this to the Version 2.1.0 milestone Dec 16, 2019
@Quintus Quintus closed this in 52c1a6b Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.