Skip to content

Smtp mailing service#107

Merged
HunteRoi merged 11 commits into
masterfrom
smtp-mailing-service
May 27, 2026
Merged

Smtp mailing service#107
HunteRoi merged 11 commits into
masterfrom
smtp-mailing-service

Conversation

@HunteRoi

@HunteRoi HunteRoi commented Sep 21, 2024

Copy link
Copy Markdown
Member

Export all models from directory default file, swap the SendGrid implementation for a SMTP one.

Description

  • Rewire the entire emailing system to avoid using a 3rd party service (SendGrid) and rely on our (not so internal) SMTP service (SendGridService --> SMTPService)

Motivation and Context

This will allow us to use preset emails from the Henallux and will then avoid falling into the spam folder.

How Has This Been Tested?

On the server (within the IESN's network).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@HunteRoi HunteRoi self-assigned this Sep 22, 2024
@HunteRoi HunteRoi force-pushed the smtp-mailing-service branch from ccaaf0d to 9aa83bc Compare October 30, 2024 11:44
@HunteRoi HunteRoi force-pushed the smtp-mailing-service branch from 8b88796 to 87dfcdf Compare June 8, 2025 13:29
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@HunteRoi HunteRoi force-pushed the smtp-mailing-service branch from 87dfcdf to 62fc5d3 Compare September 24, 2025 22:37
@sonarqubecloud

Copy link
Copy Markdown

@HunteRoi HunteRoi marked this pull request as ready for review September 29, 2025 10:02
@HunteRoi HunteRoi requested a review from DrakeXorn September 29, 2025 10:03

@DrakeXorn DrakeXorn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a general question about the imports (using the index import instead of the full path, in fact), but either way the contribution seems fine for me.

Thanks for your work !

Comment thread src/commands/others/link.ts
@HunteRoi

Copy link
Copy Markdown
Member Author

I have a general question about the imports (using the index import instead of the full path, in fact), but either way the contribution seems fine for me.

Thanks for your work !

I hope my answer satisfies you. I am unfortunately not able to detail more for the moment. This is still an ongoing process to achieve a better developer experience on the long term.

I agree that the current situation is not satisfactory as it bugs me too but I am afraid I haven't got time to get around it and find the best way to pull the benefits from the TS compiler and newest version of yarn without having issues with imports/exports.

@HunteRoi HunteRoi merged commit 7ad34b7 into master May 27, 2026
3 checks passed
@HunteRoi HunteRoi deleted the smtp-mailing-service branch May 27, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants