Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule-update ossec backup local rules issue #1572

Closed
jason-green-io opened this issue Jul 18, 2019 · 4 comments

Comments

@jason-green-io
Copy link

commented Jul 18, 2019

When LOCAL_HIDS_RULE_TUNING=no and rule-update runs at least once,
ossec/yazzuh will fail to load if duplicate rules are found in both local_rules.xml and local_rules_orig.xml.

I think ossec/yazzuh loads all the .xml files in the rules folder.

https://github.com/Security-Onion-Solutions/securityonion-rule-update/blob/5b21903a5c9bce7290378e678eea4b785ed435ba/usr/bin/rule-update#L260

@dougburks dougburks transferred this issue from Security-Onion-Solutions/securityonion-rule-update Jul 18, 2019

@dougburks dougburks self-assigned this Jul 18, 2019

@dougburks dougburks added this to To do in 16.04.6.2 via automation Jul 18, 2019

@dougburks

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Thanks @jason-green-io!

I think we'll change this to move this file into /var/ossec/rules/backup.

@dougburks

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Upon closer inspection, it looks like the script is already backing up to /var/ossec/rules/backup/ near the beginning of the script:
https://github.com/Security-Onion-Solutions/securityonion-rule-update/blob/master/usr/bin/rule-update#L73-L82

so I think the later copy in line 260 is no longer needed and can be removed altogether.

dougburks added a commit to Security-Onion-Solutions/securityonion-rule-update that referenced this issue Jul 18, 2019

dougburks added a commit to Security-Onion-Solutions/securityonion-wazuh-build that referenced this issue Jul 18, 2019

@dougburks dougburks moved this from To do to In progress in 16.04.6.2 Jul 18, 2019

dougburks added a commit to Security-Onion-Solutions/securityonion-rule-update that referenced this issue Jul 18, 2019

dougburks added a commit to Security-Onion-Solutions/securityonion-rule-update that referenced this issue Jul 18, 2019

@dougburks dougburks moved this from In progress to In Testing in 16.04.6.2 Jul 18, 2019

dougburks added a commit to Security-Onion-Solutions/securityonion-wazuh-build that referenced this issue Jul 19, 2019

@dougburks

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

@dougburks

This comment has been minimized.

@dougburks dougburks closed this Jul 25, 2019

16.04.6.2 automation moved this from In Testing to Done Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.